Zakelly commented on code in PR #24381:
URL: https://github.com/apache/flink/pull/24381#discussion_r1533244572
##########
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/CheckpointConfig.java:
##########
@@ -177,20 +177,44 @@ public boolean isCheckpointingEnabled() {
* Gets the checkpointing mode (exactly-once vs. at-least-once).
*
* @return The checkpointing mode.
+ * @deprecated Use {@link #getConsistencyMode} instead.
*/
- public CheckpointingMode getCheckpointingMode() {
+ @Deprecated
+ public org.apache.flink.streaming.api.CheckpointingMode
getCheckpointingMode() {
return
configuration.get(ExecutionCheckpointingOptions.CHECKPOINTING_MODE);
}
/**
* Sets the checkpointing mode (exactly-once vs. at-least-once).
*
* @param checkpointingMode The checkpointing mode.
+ * @deprecated Use {@link #setConsistencyMode} instead.
*/
- public void setCheckpointingMode(CheckpointingMode checkpointingMode) {
+ @Deprecated
+ public void setCheckpointingMode(
+ org.apache.flink.streaming.api.CheckpointingMode
checkpointingMode) {
configuration.set(ExecutionCheckpointingOptions.CHECKPOINTING_MODE,
checkpointingMode);
}
+ /**
+ * Gets the checkpointing consistency mode (exactly-once vs.
at-least-once).
+ *
+ * @return The checkpointing mode.
+ */
+ public CheckpointingMode getConsistencyMode() {
Review Comment:
I'd change the API name `get/setConsistencyMode` to
`get/setCheckpointingConsistencyMode` and add some description showing the
relationship between the name `CheckpointingConsistencyMode` and
`CheckpointingMode`. But I'd suggest keep `CheckpointingMode` as it is since it
is a first class citizen of Flink and widely accepted by users. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
