[ 
https://issues.apache.org/jira/browse/FLINK-5023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15687291#comment-15687291
 ] 

ASF GitHub Bot commented on FLINK-5023:
---------------------------------------

Github user aljoscha commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2768#discussion_r89162070
  
    --- Diff: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/triggers/Trigger.java
 ---
    @@ -179,12 +179,13 @@ public TriggerResult onMerge(W window, OnMergeContext 
ctx) throws Exception {
                 *
                 * @param stateDescriptor The StateDescriptor that contains the 
name and type of the
                 *                        state that is being accessed.
    +            * @param <V>             The type of the values in the state.
                 * @param <S>             The type of the state.
                 * @return The partitioned state object.
                 * @throws UnsupportedOperationException Thrown, if no 
partitioned state is available for the
                 *                                       function (function is 
not part os a KeyedStream).
                 */
    -           <S extends State> S getPartitionedState(StateDescriptor<S, ?> 
stateDescriptor);
    +           <V, S extends State<V>> S 
getPartitionedState(StateDescriptor<S> stateDescriptor);
    --- End diff --
    
    Same thing as elsewhere: we don't need `V`.


> Add get() method in State interface
> -----------------------------------
>
>                 Key: FLINK-5023
>                 URL: https://issues.apache.org/jira/browse/FLINK-5023
>             Project: Flink
>          Issue Type: Improvement
>          Components: State Backends, Checkpointing
>            Reporter: Xiaogang Shi
>            Assignee: Xiaogang Shi
>
> Currently, the only method provided by the State interface is `clear()`. I 
> think we should provide another method called `get()` to return the 
> structured value (e.g., value, list, or map) under the current key. 
> In fact, the functionality of `get()` has already been implemented in all 
> types of states: e.g., `value()` in ValueState and `get()` in ListState. The 
> modification to the interface can better abstract these states.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to