zhuzhurk commented on code in PR #24475:
URL: https://github.com/apache/flink/pull/24475#discussion_r1524746682
##########
flink-core/src/test/java/org/apache/flink/api/dag/TransformationTest.java:
##########
@@ -125,19 +145,34 @@ public void
testDeclareManagedMemorySlotScopeUseCaseFailWrongScope() {
/** A test implementation of {@link Transformation}. */
private static class TestTransformation<T> extends Transformation<T> {
-
- public TestTransformation(String name, TypeInformation<T> outputType,
int parallelism) {
Review Comment:
It's better to introduce a `TestTwoInputTransformation` which inherits
`TwoInputTransformation`.
Otherwise we are testing some testing logic instead of production logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
