schulzp commented on PR #39: URL: https://github.com/apache/flink-connector-opensearch/pull/39#issuecomment-1992274982
Hey @hajimeni! > The CI error seems to be caused by differences in files under the archunit-violations path. > It was resolved in the following PR. https://github.com/apache/flink-connector-opensearch/pull/21 The PR you mentioned has been merged in 2023, that way before I opened this one. I'd like to help here but I feel lost. If I run `mvn clean verify` (against flink 1.17.1) all tests pass. Once I add `-Dflink.version=1.18.1` the archunit violations show up and are written to the following files: * `4382f1f0-807a-45ff-97d8-42f72b6e9484` (updated) * `eb4a59cf-22af-4223-8dfd-0ebc17ed342d` (new file) * `stored.rules` (adds `…342d` to the list) What should happen next? Is the build process supposed to just accept those violations instead of failing? Is there any documentation on archunit in the context of flink projects? > Additionally, Flink version has been updated to 1.18.1, Please fix CI target version. That's out of scope of this PR, isn't it? I looked at [the PR workflow for flink-connector-elasticsearch](/apache/flink-connector-elasticsearch/blob/main/.github/workflows/push_pr.yml) but even there it's 1.18-SNAPSHOT. What is supposed to be changed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
