WencongLiu commented on code in PR #24398: URL: https://github.com/apache/flink/pull/24398#discussion_r1520965160
########## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/PartitionAggregateOperator.java: ########## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.streaming.api.operators; + +import org.apache.flink.annotation.Internal; +import org.apache.flink.api.common.functions.AggregateFunction; +import org.apache.flink.streaming.runtime.streamrecord.StreamRecord; + +import static org.apache.flink.util.Preconditions.checkNotNull; + +/** + * The {@link PartitionAggregateOperator} is used to apply the aggregate transformation on all + * records of each partition. Each partition contains all records of a subtask. + */ +@Internal +public class PartitionAggregateOperator<IN, ACC, OUT> + extends AbstractUdfStreamOperator<OUT, AggregateFunction<IN, ACC, OUT>> + implements OneInputStreamOperator<IN, OUT>, BoundedOneInput { + + private final AggregateFunction<IN, ACC, OUT> aggregateFunction; + + private ACC currentAccumulator = null; + + public PartitionAggregateOperator(AggregateFunction<IN, ACC, OUT> aggregateFunction) { + super(aggregateFunction); + this.aggregateFunction = aggregateFunction; + } + + @Override + public void open() throws Exception { + super.open(); + this.currentAccumulator = checkNotNull(aggregateFunction.createAccumulator()); + } + + @Override + public void processElement(StreamRecord<IN> element) throws Exception { + aggregateFunction.add(element.getValue(), currentAccumulator); + } + + @Override + public void endInput() throws Exception { + TimestampedCollector<OUT> outputCollector = new TimestampedCollector<>(output); Review Comment: This change is indeed unnecessary. Currently, the data will first be converted into `StreamRecord` and then directly emitted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
