Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2840#discussion_r88977919
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/DataSetAggregate.scala
 ---
    @@ -157,4 +161,41 @@ class DataSetAggregate(
           case _ => result
         }
       }
    +
    +  /**
    +    * Dummy [[Row]] into a [[DataSet]] for result after map operations.
    +    * @param mapOperator after which insert dummy records
    +    * @param tableEnv [[BatchTableEnvironment]] for getting rel builder 
and type factory
    +    * @tparam IN mapOperator input type
    +    * @tparam OUT mapOperator output type
    +    * @return DataSet of type Row is contains null literals for columns
    +    */
    +  private def dummyRow[IN,OUT](
    --- End diff --
    
    I would not call this "Dummy row" but "Null row". Dummy row sounds like a 
useless mock up, but our null row has a good purpose.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to