gyfora commented on PR #787:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/787#issuecomment-1985808993
I have some concerns about this change:
1. It doesn't work with custom slot sharing configuration which is very
common
2. It provides almost no benefit with large taskmanager sizes / low number
of task slots.
3. It goes against some basic design philosophy in the autoscaler such that
we do not scale vertices beyond their target capacity. It ties to @mxm 's
question why the logic wouldn't apply to all vertices?
Taking that one step further why don't we scale all vertices to the same
parallelism at that point? That would naturally cause more resource usage and
less throughput. By the same logic I don't think we should scale even the
largest ones further.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
