Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2845#discussion_r88910876
  
    --- Diff: 
flink-streaming-connectors/flink-connector-filesystem/src/test/java/org/apache/flink/streaming/connectors/fs/RollingSinkITCase.java
 ---
    @@ -638,6 +644,231 @@ public void flatMap(Tuple2<Integer, String> value,
                Assert.assertEquals(8, numFiles);
        }
     
    +   private static final String PART_PREFIX = "part";
    +   private static final String PENDING_SUFFIX = ".pending";
    +   private static final String IN_PROGRESS_SUFFIX = ".in-progress";
    +   private static final String VALID_LENGTH_SUFFIX = ".valid";
    +
    +   @Test
    +   public void testBucketStateTransitions() throws Exception {
    +           final File outDir = tempFolder.newFolder();
    +
    +           OneInputStreamOperatorTestHarness<String, Object> testHarness = 
createRescalingTestSink(outDir, 1, 0);
    +           testHarness.setup();
    +           testHarness.open();
    +
    +           testHarness.setProcessingTime(0L);
    +
    +           testHarness.processElement(new StreamRecord<>("test1", 1L)); // 
we have a bucket size of 5 bytes
    --- End diff --
    
    the comment should include the conclusion the reader is supposed to arrive 
on: that every record goes in a separate file.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to