morazow commented on code in PR #181:
URL: https://github.com/apache/flink-docker/pull/181#discussion_r1507185293


##########
.github/workflows/snapshot.yml:
##########
@@ -36,34 +36,34 @@ jobs:
     strategy:
       max-parallel: 1
       matrix:
-        java_version: [8, 11]
         build:
           - flink_version: 1.20-SNAPSHOT
+            java_version: [8, 11, 17, 21]
             branch: dev-master
           - flink_version: 1.19-SNAPSHOT
+            java_version: [8, 11, 17, 21]
             branch: dev-1.19
           - flink_version: 1.18-SNAPSHOT
+            java_version: [8, 11, 17]
             branch: dev-1.18
           - flink_version: 1.17-SNAPSHOT
+            java_version: [8, 11]
             branch: dev-1.17
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           ref: ${{ matrix.build.branch }}
 
       - name: Set up QEMU
-        uses: docker/setup-qemu-action@v1
-        with:
-          image: tonistiigi/binfmt:latest
-          platforms: all
+        uses: docker/setup-qemu-action@v3
 
       - name: Set up Docker Buildx
-        uses: docker/setup-buildx-action@v1
+        uses: docker/setup-buildx-action@v3
 
       - name: Log in to the Container registry
-        uses: docker/login-action@v1
+        uses: docker/login-action@v3
         with:
-          registry: ghcr.io
+          registry: ${{ env.REGISTRY }}

Review Comment:
   This is set in the beginning of the file, on the `env` part
   
   ```
   env:
     REGISTRY:    ghcr.io
     OWNER:       apache
     IMAGE_REPO:  flink-docker
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to