Zakelly commented on code in PR #24396:
URL: https://github.com/apache/flink/pull/24396#discussion_r1505277616
##########
docs/content/docs/ops/state/savepoints.md:
##########
@@ -208,7 +208,13 @@ This submits a job and specifies a savepoint to resume
from. You may give a path
#### Allowing Non-Restored State
-By default, the resume operation will try to map all state of the savepoint
back to the program you are restoring with. If you dropped an operator, you can
allow to skip state that cannot be mapped to the new program via
`--allowNonRestoredState` (short: `-n`) option:
+By default, the resume operation will try to map all state of the savepoint
back to the program you are restoring with. If you dropped an operator, you can
allow to skip state that cannot be mapped to the new program via
`--allowNonRestoredState` (short: `-n`) option.
+
+{{< hint warning >}}
+Improper usage of this feature could result in significant issues with the
correctness of the application. It is crucial to verify that any remaining
states can be accurately mapped to the appropriate operators.
+It is worth noting that operator UIDs are reassigned based on topological
order by default, which may lead to incorrect associations between states and
operators.
+To prevent such mismatches, it is advisable to explicitly [assign UIDs] ({{<
ref "docs/ops/production_ready" >}}/#set-uuids-for-all-operators) to all
operators in a DataStream job. In other scenarios involving mismatches, it is
necessary to start the new job discarding all states.
Review Comment:
what do you mean by 'In other scenarios involving mismatches, it is
necessary to start the new job discarding all states.'
##########
docs/content/docs/ops/state/savepoints.md:
##########
@@ -208,7 +208,13 @@ This submits a job and specifies a savepoint to resume
from. You may give a path
#### Allowing Non-Restored State
-By default, the resume operation will try to map all state of the savepoint
back to the program you are restoring with. If you dropped an operator, you can
allow to skip state that cannot be mapped to the new program via
`--allowNonRestoredState` (short: `-n`) option:
+By default, the resume operation will try to map all state of the savepoint
back to the program you are restoring with. If you dropped an operator, you can
allow to skip state that cannot be mapped to the new program via
`--allowNonRestoredState` (short: `-n`) option.
+
+{{< hint warning >}}
+Improper usage of this feature could result in significant issues with the
correctness of the application. It is crucial to verify that any remaining
states can be accurately mapped to the appropriate operators.
+It is worth noting that operator UIDs are reassigned based on topological
order by default, which may lead to incorrect associations between states and
operators.
Review Comment:
More description for consequence? Such as
```suggestion
It is worth noting that operator UIDs are reassigned based on topological
order by default, which may lead to incorrect associations between states and
operators, thus consequently the state is not correctly restored as wished.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
