Zakelly commented on PR #24374: URL: https://github.com/apache/flink/pull/24374#issuecomment-1963592409
> > Hi @spoon-lz , thanks for your contribution! At first glance of your PR, I would suggest keep the old `org.apache.flink.streaming.api.CheckpointingMode` and mark as deprecated. However it is required to start a discussion about such deprecation on dev mailing list first. I will start the discussion and work on the deprecation in Flink 1.19 (will soon be released this month). > > If `CheckpointingMode` is not moved, do we need to copy the same class in the flink-core module? Otherwise, dependency problems will occur. Or wait until the discussion is over before modifying this PR. I suggest both keep the old one and the new introduced one. All the internal usage will use the new one, while only user-facing APIs leverage the old one. We could wait the conclusion of the discussion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
