sharath1709 commented on code in PR #24035:
URL: https://github.com/apache/flink/pull/24035#discussion_r1498451041
##########
docs/content/docs/connectors/table/formats/protobuf.md:
##########
@@ -149,9 +149,12 @@ Format Options
<td style="word-wrap: break-word;">false</td>
<td>Boolean</td>
<td>
- This option only works if the generated class's version is proto2.
If this value is set to true, the format will read empty values as the default
values defined in the proto file.
+ If this value is set to true, the format will read empty values as
the default values defined in the proto file.
If the value is set to false, the format will generate null values
if the data element does not exist in the binary protobuf message.
- If the proto syntax is proto3, this value will forcibly be set to
true, because proto3's standard is to use default values.
+ If the proto syntax is proto3, this value needs to be set to true by
users when using proto version older than 3.15 because proto3
Review Comment:
@libenchao In case you haven't noticed, I'd also like to point out that this
is a breaking change as older SQL queries without proper null checking can fail
after this change. With that being said, this is a step in the right direction
by making the default value to be the better performance choise
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
