[ https://issues.apache.org/jira/browse/FLINK-34434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17818613#comment-17818613 ]
Yangze Guo commented on FLINK-34434: ------------------------------------ master: 15af3e49ca42fea1e3f6c53d6d1498315b1322ac 1a494bc1f04571b8b8248d7c2c1af364222a0c61 1.18: e95cb6e73900fbbc2039407be1bd87271b2a950b 21cfe998f4fb21afe24ceb8b6f4fef180e89b9e9 > DefaultSlotStatusSyncer doesn't complete the returned future > ------------------------------------------------------------ > > Key: FLINK-34434 > URL: https://issues.apache.org/jira/browse/FLINK-34434 > Project: Flink > Issue Type: Bug > Components: Runtime / Coordination > Affects Versions: 1.17.2, 1.19.0, 1.18.1, 1.20.0 > Reporter: Matthias Pohl > Assignee: Yangze Guo > Priority: Major > Labels: pull-request-available > > When looking into FLINK-34427 (unrelated), I noticed an odd line in > [DefaultSlotStatusSyncer:155|https://github.com/apache/flink/blob/15fe1653acec45d7c7bac17071e9773a4aa690a4/flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/DefaultSlotStatusSyncer.java#L155] > where we complete a future that should be already completed (because the > callback is triggered after the {{requestFuture}} is already completed in > some way. Shouldn't we complete the {{returnedFuture}} instead? > I'm keeping the priority at {{Major}} because it doesn't seem to have been an > issue in the past. -- This message was sent by Atlassian Jira (v8.20.10#820010)