dawidwys commented on code in PR #23171: URL: https://github.com/apache/flink/pull/23171#discussion_r1491059814
########## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ArrayIntersectFunction.java: ########## @@ -0,0 +1,156 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.runtime.functions.scalar; + +import org.apache.flink.annotation.Internal; +import org.apache.flink.table.api.DataTypes; +import org.apache.flink.table.api.Expressions; +import org.apache.flink.table.data.ArrayData; +import org.apache.flink.table.data.GenericArrayData; +import org.apache.flink.table.functions.BuiltInFunctionDefinitions; +import org.apache.flink.table.functions.FunctionContext; +import org.apache.flink.table.functions.SpecializedFunction; +import org.apache.flink.table.types.CollectionDataType; +import org.apache.flink.table.types.DataType; +import org.apache.flink.util.FlinkRuntimeException; + +import javax.annotation.Nullable; + +import java.lang.invoke.MethodHandle; +import java.util.ArrayList; +import java.util.HashSet; +import java.util.List; +import java.util.Set; + +import static org.apache.flink.table.api.Expressions.$; + +/** Implementation of {@link BuiltInFunctionDefinitions#ARRAY_INTERSECT}. */ +@Internal +public class ArrayIntersectFunction extends BuiltInScalarFunction { + private final ArrayData.ElementGetter elementGetter; + private final SpecializedFunction.ExpressionEvaluator hashcodeEvaluator; + private final SpecializedFunction.ExpressionEvaluator equalityEvaluator; + private transient MethodHandle hashcodeHandle; + private transient MethodHandle equalityHandle; + + public ArrayIntersectFunction(SpecializedFunction.SpecializedContext context) { + super(BuiltInFunctionDefinitions.ARRAY_INTERSECT, context); + final DataType dataType = + ((CollectionDataType) context.getCallContext().getArgumentDataTypes().get(0)) + .getElementDataType() + .toInternal(); + elementGetter = ArrayData.createElementGetter(dataType.toInternal().getLogicalType()); + hashcodeEvaluator = + context.createEvaluator( + Expressions.call("$HASHCODE$1", $("element1")), + DataTypes.INT(), + DataTypes.FIELD("element1", dataType.notNull().toInternal())); + equalityEvaluator = + context.createEvaluator( + $("element1").isEqual($("element2")), + DataTypes.BOOLEAN(), + DataTypes.FIELD("element1", dataType.notNull().toInternal()), + DataTypes.FIELD("element2", dataType.notNull().toInternal())); + } + + @Override + public void open(FunctionContext context) throws Exception { + hashcodeHandle = hashcodeEvaluator.open(context); + equalityHandle = equalityEvaluator.open(context); + } + + public @Nullable ArrayData eval(ArrayData array1, ArrayData array2) { + try { + if (array1 == null || array2 == null) { + return null; + } + List<Object> list = new ArrayList<>(); + Set<ObjectContainer> seen = new HashSet<>(); + + boolean isNullPresentInArrayTwo = false; + for (int pos = 0; pos < array2.size(); pos++) { + final Object element = elementGetter.getElementOrNull(array2, pos); + if (element == null) { + isNullPresentInArrayTwo = true; + } else { + ObjectContainer objectContainer = new ObjectContainer(element); + seen.add(objectContainer); + } + } + boolean isNullPresentInArrayOne = false; + for (int pos = 0; pos < array1.size(); pos++) { + final Object element = elementGetter.getElementOrNull(array1, pos); + if (element == null) { + isNullPresentInArrayOne = true; Review Comment: Can't we just check if it was present in the second array and add it to the `list`? ########## flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java: ########## @@ -388,7 +388,16 @@ ANY, and(logical(LogicalTypeRoot.BOOLEAN), LITERAL) .inputTypeStrategy(sequence(ANY)) .outputTypeStrategy(nullableIfArgs(explicit(DataTypes.INT().notNull()))) .runtimeProvided() - .internal() Review Comment: Why did you remove the `internal` here? ########## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ArrayIntersectFunction.java: ########## @@ -0,0 +1,156 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.runtime.functions.scalar; + +import org.apache.flink.annotation.Internal; +import org.apache.flink.table.api.DataTypes; +import org.apache.flink.table.api.Expressions; +import org.apache.flink.table.data.ArrayData; +import org.apache.flink.table.data.GenericArrayData; +import org.apache.flink.table.functions.BuiltInFunctionDefinitions; +import org.apache.flink.table.functions.FunctionContext; +import org.apache.flink.table.functions.SpecializedFunction; +import org.apache.flink.table.types.CollectionDataType; +import org.apache.flink.table.types.DataType; +import org.apache.flink.util.FlinkRuntimeException; + +import javax.annotation.Nullable; + +import java.lang.invoke.MethodHandle; +import java.util.ArrayList; +import java.util.HashSet; +import java.util.List; +import java.util.Set; + +import static org.apache.flink.table.api.Expressions.$; + +/** Implementation of {@link BuiltInFunctionDefinitions#ARRAY_INTERSECT}. */ +@Internal +public class ArrayIntersectFunction extends BuiltInScalarFunction { + private final ArrayData.ElementGetter elementGetter; + private final SpecializedFunction.ExpressionEvaluator hashcodeEvaluator; + private final SpecializedFunction.ExpressionEvaluator equalityEvaluator; + private transient MethodHandle hashcodeHandle; + private transient MethodHandle equalityHandle; + + public ArrayIntersectFunction(SpecializedFunction.SpecializedContext context) { + super(BuiltInFunctionDefinitions.ARRAY_INTERSECT, context); + final DataType dataType = + ((CollectionDataType) context.getCallContext().getArgumentDataTypes().get(0)) + .getElementDataType() + .toInternal(); + elementGetter = ArrayData.createElementGetter(dataType.toInternal().getLogicalType()); + hashcodeEvaluator = + context.createEvaluator( + Expressions.call("$HASHCODE$1", $("element1")), + DataTypes.INT(), + DataTypes.FIELD("element1", dataType.notNull().toInternal())); + equalityEvaluator = + context.createEvaluator( + $("element1").isEqual($("element2")), + DataTypes.BOOLEAN(), + DataTypes.FIELD("element1", dataType.notNull().toInternal()), + DataTypes.FIELD("element2", dataType.notNull().toInternal())); + } + + @Override + public void open(FunctionContext context) throws Exception { + hashcodeHandle = hashcodeEvaluator.open(context); + equalityHandle = equalityEvaluator.open(context); + } + + public @Nullable ArrayData eval(ArrayData array1, ArrayData array2) { + try { + if (array1 == null || array2 == null) { + return null; + } + List<Object> list = new ArrayList<>(); + Set<ObjectContainer> seen = new HashSet<>(); + + boolean isNullPresentInArrayTwo = false; + for (int pos = 0; pos < array2.size(); pos++) { + final Object element = elementGetter.getElementOrNull(array2, pos); + if (element == null) { + isNullPresentInArrayTwo = true; + } else { + ObjectContainer objectContainer = new ObjectContainer(element); + seen.add(objectContainer); + } + } + boolean isNullPresentInArrayOne = false; + for (int pos = 0; pos < array1.size(); pos++) { + final Object element = elementGetter.getElementOrNull(array1, pos); + if (element == null) { + isNullPresentInArrayOne = true; + } else { + ObjectContainer objectContainer = new ObjectContainer(element); + if (seen.contains(objectContainer)) { + list.add(element); + } + } + } + if (isNullPresentInArrayTwo && isNullPresentInArrayOne) { Review Comment: The same question as in the other PR. Shouldn't we care about the order within the first array? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
