mxm commented on code in PR #762:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/762#discussion_r1490811369
##########
flink-autoscaler-plugin-jdbc/src/main/java/org/apache/flink/autoscaler/jdbc/state/JdbcAutoScalerStateStore.java:
##########
@@ -189,6 +191,28 @@ public void removeParallelismOverrides(Context jobContext)
{
jdbcStateStore.removeSerializedState(getSerializeKey(jobContext),
PARALLELISM_OVERRIDES);
}
+ @Override
+ public void storeConfigOverrides(Context jobContext, Configuration
configOverrides) {
+ jdbcStateStore.putSerializedState(
+ getSerializeKey(jobContext),
+ CONFIG_OVERRIDES,
+ serializeParallelismOverrides(configOverrides.toMap()));
Review Comment:
It's not because the serialization is identical but it could become a bug,
you are right. Thanks for spotting!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
