zentol commented on code in PR #24292: URL: https://github.com/apache/flink/pull/24292#discussion_r1485888366
########## flink-core/src/main/java/org/apache/flink/util/MdcUtils.java: ########## @@ -0,0 +1,107 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.util; + +import org.apache.flink.api.common.JobID; + +import org.slf4j.MDC; + +import java.util.concurrent.Callable; +import java.util.concurrent.Executor; +import java.util.concurrent.ExecutorService; +import java.util.concurrent.ScheduledExecutorService; + +import static org.apache.flink.util.Preconditions.checkArgument; + +// todo: tests + +/** Utility class to manage common Flink attributes in {@link MDC} (only {@link JobID} ATM). */ +public class MdcUtils { + + public static final String JOB_ID = "flink-job-id"; + + /** Add the given {@link JobID} to {@link MDC}. */ + public static void addJobID(JobID jobID) { + MDC.put(JOB_ID, jobID.toHexString()); + } + + /** Remove any {@link JobID} from {@link MDC}. */ + public static void removeJobID() { + // todo: restore original jid if present Review Comment: This is an important one, especially because it has performance-ramifications. ########## flink-core/src/main/java/org/apache/flink/util/MdcUtils.java: ########## @@ -0,0 +1,107 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.util; + +import org.apache.flink.api.common.JobID; + +import org.slf4j.MDC; + +import java.util.concurrent.Callable; +import java.util.concurrent.Executor; +import java.util.concurrent.ExecutorService; +import java.util.concurrent.ScheduledExecutorService; + +import static org.apache.flink.util.Preconditions.checkArgument; + +// todo: tests + +/** Utility class to manage common Flink attributes in {@link MDC} (only {@link JobID} ATM). */ +public class MdcUtils { + + public static final String JOB_ID = "flink-job-id"; + + /** Add the given {@link JobID} to {@link MDC}. */ + public static void addJobID(JobID jobID) { + MDC.put(JOB_ID, jobID.toHexString()); + } + + /** Remove any {@link JobID} from {@link MDC}. */ + public static void removeJobID() { + // todo: restore original jid if present Review Comment: This is an important one because it has performance-ramifications. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
