[
https://issues.apache.org/jira/browse/FLINK-34148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17812230#comment-17812230
]
Chesnay Schepler commented on FLINK-34148:
------------------------------------------
Just chiming in to point out that the shade-plugin version shouldn't be
relevant; we used 3.4.1 in Flink already in 1.17 and didn't run into issues. We
only ever had issue due to more recent maven, so I'm questioning the
conclusions in this ticket a bit.
We should be able to just bump the shade-plugin and call it a day.
> Potential regression (Jan. 13): stringWrite with Java8
> ------------------------------------------------------
>
> Key: FLINK-34148
> URL: https://issues.apache.org/jira/browse/FLINK-34148
> Project: Flink
> Issue Type: Improvement
> Components: API / Type Serialization System
> Reporter: Zakelly Lan
> Priority: Blocker
> Fix For: 1.19.0
>
>
> Significant drop of performance in stringWrite with Java8 from commit
> [881062f352|https://github.com/apache/flink/commit/881062f352f8bf8c21ab7cbea95e111fd82fdf20]
> to
> [5d9d8748b6|https://github.com/apache/flink/commit/5d9d8748b64ff1a75964a5cd2857ab5061312b51]
> . It only involves strings not so long (128 or 4).
> stringWrite.128.ascii(Java8) baseline=1089.107756 current_value=754.52452
> stringWrite.128.chinese(Java8) baseline=504.244575 current_value=295.358989
> stringWrite.128.russian(Java8) baseline=655.582639 current_value=421.030188
> stringWrite.4.chinese(Java8) baseline=9598.791964 current_value=6627.929927
> stringWrite.4.russian(Java8) baseline=11070.666415 current_value=8289.95767
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
