MartijnVisser commented on PR #76:
URL: 
https://github.com/apache/flink-connector-kafka/pull/76#issuecomment-1911058347

   > I don't think we need 3.1 to support Flink 1.17 and Flink 1.18. We can use 
3.0 for the purpose of supporting 1.17, but we need to continue supporting 
patch fixes on it.
   
   We don't need it indeed. We just need to decide to which branch/version 
we'll need to submit backports. 
   
   I'm inclined to do the following:
   1. Review/merge https://github.com/apache/flink-connector-kafka/pull/80 and 
then cut a `v3.1` release branch, and make a release. That means that `v3.1` 
would have support for 1.17 and 1.18
   2. Afterwards, merge this PR and drop support for both 1.17 and 1.18 in 
`main` and only support 1.19. Since we're breaking the SinkV2 implementation 
with Flink 1.19, that would be a new Flink Kafka major version anyway, so when 
1.19 is released, we would cut `main` and make that `v4.0`. We would then have 
to do backports to both `v3.1` and `v4.0`, since we'll need to support the last 
two minor Flink versions. For now that would be 1.17 and 1.18 (which are in 
`v3.1`), and when 1.19 is released we would backport to both `v3.1` and `v4.0`. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to