nicusX commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1464922614
########## amp-request-signer/src/main/java/org/apache/flink/connector/prometheus/sink/aws/AWS4SignerBase.java: ########## @@ -0,0 +1,290 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.connector.prometheus.sink.aws; + +import com.amazonaws.util.BinaryUtils; + +import javax.crypto.Mac; +import javax.crypto.spec.SecretKeySpec; + +import java.io.UnsupportedEncodingException; +import java.net.URL; +import java.net.URLEncoder; +import java.security.MessageDigest; +import java.text.SimpleDateFormat; +import java.util.ArrayList; +import java.util.Collections; +import java.util.Iterator; +import java.util.List; +import java.util.Map; +import java.util.SimpleTimeZone; +import java.util.SortedMap; +import java.util.TreeMap; + +/** Common methods and properties for all AWS4 signer variants. */ +public abstract class AWS4SignerBase { + + /** SHA256 hash of an empty request body. */ + public static final String EMPTY_BODY_SHA256 = + "e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855"; + + public static final String UNSIGNED_PAYLOAD = "UNSIGNED-PAYLOAD"; + + public static final String SCHEME = "AWS4"; + public static final String ALGORITHM = "HMAC-SHA256"; + public static final String TERMINATOR = "aws4_request"; + + /** format strings for the date/time and date stamps required during signing. */ + public static final String ISO_8601_BASIC_FORMAT = "yyyyMMdd'T'HHmmss'Z'"; + + public static final String DATE_STRING_FORMAT = "yyyyMMdd"; + + protected URL endpointUrl; + protected String httpMethod; + protected String serviceName; + protected String regionName; + + protected final SimpleDateFormat dateTimeFormat; + protected final SimpleDateFormat dateStampFormat; + + /** + * Create a new AWS V4 signer. + * + * @param endpointUrl The service endpoint, including the path to any resource. + * @param httpMethod The HTTP verb for the request, e.g. GET. + * @param serviceName The signing name of the service, e.g. 's3'. + * @param regionName The system name of the AWS region associated with the endpoint, e.g. + * us-east-1. + */ + public AWS4SignerBase( + URL endpointUrl, String httpMethod, String serviceName, String regionName) { + this.endpointUrl = endpointUrl; + this.httpMethod = httpMethod; + this.serviceName = serviceName; + this.regionName = regionName; + + dateTimeFormat = new SimpleDateFormat(ISO_8601_BASIC_FORMAT); + dateTimeFormat.setTimeZone(new SimpleTimeZone(0, "UTC")); + dateStampFormat = new SimpleDateFormat(DATE_STRING_FORMAT); + dateStampFormat.setTimeZone(new SimpleTimeZone(0, "UTC")); Review Comment: This formatter is used to build the `x-amz-date` request header that must be in UTC, as documented here https://docs.aws.amazon.com/IAM/latest/UserGuide/signing-elements.html#date -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
