mayuehappy commented on PR #24173: URL: https://github.com/apache/flink/pull/24173#issuecomment-1907651213
@JunRuiLee Thanks for joining the disscussion . > the PR skips the creation of the checkpoint coordinator when disabling the checkpoint scheduling Yes, actually I think that's also why we made this change. Because Flink does not require the creation of components such as CheckpointCoordinator or CheckpointIDCounter in many scenarios, such as OLAP or Flink Batch. In these scenarios, I believe it is reasonable not to create a CheckpointCoordinator. > For instance, could this also prevent triggering savepoints? Yes. If disabling Checkpoint, the savepoint cannot be triggered after Change. But I think this issue is indeed worth discussing. In my opinion, if the user disable Checkpoint, does it mean that the user can accept state loss. I can't imagine a scenario where users don't need Checkpoint but need Savepoint. So i thinks it's fine here or we need notice the user savepoint can only be triggered while Checkpoint is enabled . WDYT -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
