reswqa commented on code in PR #24129:
URL: https://github.com/apache/flink/pull/24129#discussion_r1457239038


##########
flink-core/src/main/java/org/apache/flink/api/common/ExecutionConfig.java:
##########
@@ -666,6 +666,18 @@ public boolean isForceKryoEnabled() {
         return configuration.get(PipelineOptions.FORCE_KRYO);
     }
 
+    public void enableForceAvroKryo() {
+        setForceAvroKryo(true);
+    }
+
+    private void setForceAvroKryo(boolean forceAvroKryo) {
+        configuration.set(PipelineOptions.FORCE_KRYO_AVRO, forceAvroKryo);
+    }
+
+    public Optional<Boolean> isForceAvroKryoEnable() {
+        return configuration.getOptional(PipelineOptions.FORCE_KRYO_AVRO);
+    }
+

Review Comment:
   In fact, these methods will be moved to `SerializerConfig` introduced by 
`FLINK-34090`. I just opened the PR too early, rebase is essential actually. 
I've marked this one as draft to avoid confusion like this. XD)



##########
flink-core/src/main/java/org/apache/flink/api/common/ExecutionConfig.java:
##########
@@ -666,6 +666,18 @@ public boolean isForceKryoEnabled() {
         return configuration.get(PipelineOptions.FORCE_KRYO);
     }
 
+    public void enableForceAvroKryo() {
+        setForceAvroKryo(true);
+    }
+
+    private void setForceAvroKryo(boolean forceAvroKryo) {
+        configuration.set(PipelineOptions.FORCE_KRYO_AVRO, forceAvroKryo);
+    }
+
+    public Optional<Boolean> isForceAvroKryoEnable() {
+        return configuration.getOptional(PipelineOptions.FORCE_KRYO_AVRO);
+    }
+

Review Comment:
   In fact, these methods will be moved to `SerializerConfig` introduced by 
FLINK-34090. I just opened the PR too early, rebase is essential actually. I've 
marked this one as draft to avoid confusion like this. XD)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to