xiangforever2014 commented on code in PR #24058:
URL: https://github.com/apache/flink/pull/24058#discussion_r1448416625
##########
flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/SavepointRestoreSettings.java:
##########
@@ -163,14 +163,16 @@ public static SavepointRestoreSettings forPath(
public static void toConfiguration(
final SavepointRestoreSettings savepointRestoreSettings,
final Configuration configuration) {
- configuration.set(
- SavepointConfigOptions.SAVEPOINT_IGNORE_UNCLAIMED_STATE,
- savepointRestoreSettings.allowNonRestoredState());
- configuration.set(
- SavepointConfigOptions.RESTORE_MODE,
savepointRestoreSettings.getRestoreMode());
- final String savepointPath = savepointRestoreSettings.getRestorePath();
- if (savepointPath != null) {
- configuration.setString(SavepointConfigOptions.SAVEPOINT_PATH,
savepointPath);
+ if (!savepointRestoreSettings.equals(SavepointRestoreSettings.none()))
{
Review Comment:
Yes I also notice this behavior, it seems a little bit weird, since it will
only write the config of `SAVEPOINT_IGNORE_UNCLAIMED_STATE` and `RESTORE_MODE`
in the method `toConfiguration` if we pass a SavepointRestoreSettings.none to
it, the savepoint path will not write to the config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
