ljz2051 commented on code in PR #24066:
URL: https://github.com/apache/flink/pull/24066#discussion_r1448240936
##########
flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/SavepointRestoreSettings.java:
##########
@@ -105,12 +105,14 @@ public boolean equals(Object o) {
SavepointRestoreSettings that = (SavepointRestoreSettings) o;
return allowNonRestoredState == that.allowNonRestoredState
- && (Objects.equals(restorePath, that.restorePath));
+ && Objects.equals(restorePath, that.restorePath)
+ && Objects.equals(restoreMode, that.restoreMode);
}
@Override
public int hashCode() {
int result = restorePath != null ? restorePath.hashCode() : 0;
+ result = 31 * result + (restoreMode != null ? restoreMode.hashCode() :
0);
Review Comment:
The restoreMode property in SavepointRestoreSettings should be \@Nonnull ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
