XComp commented on code in PR #23970: URL: https://github.com/apache/flink/pull/23970#discussion_r1446249763
########## .github/actions/run_mvn/action.yml: ########## @@ -0,0 +1,42 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# +--- +name: "Runs Maven Command" Review Comment: The environment is not shared between steps. For environment variables, we would have to use the `echo "<var-name>=<var-value>" >> $GITHUB_OUTPUT` to make the variables available. I'm hesitent to try exporting functions into `GITHUB_OUTPUT`, though. The custom action for Maven commands gives us the ability to call the `run_mvn` also from within the GHA workflow. It seems like the steps are still executed in some kind of sandbox. That's why I feel like source'ing `maven-utils.sh` each time should be ok. :thinking: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
