zhougit86 commented on code in PR #23323:
URL: https://github.com/apache/flink/pull/23323#discussion_r1444356621
##########
flink-formats/flink-protobuf/src/test/java/org/apache/flink/formats/protobuf/BigPbProtoToRowTest.java:
##########
@@ -82,9 +82,52 @@ public void testSimple() throws Exception {
.putMapField33("key2", "value2")
.build();
+ String[][] projectedField =
Review Comment:
> Can you add a UT to verify your logic without modifying the original
UT，the comment applies to all UT，WDYT?
@ljw-hit Hi, this is because I changed the constructor of
PbRowDataDeserializationSchema, the projectedFields is a mandatory parameter.
And for most cases, I created a all field convertor. So it takes the same PB
input.
`public ProtoToRowConverter(
RowType rowType, PbFormatConfig formatConfig, String[][]
projectedFields)
throws PbCodegenException {`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
