WencongLiu commented on code in PR #23905: URL: https://github.com/apache/flink/pull/23905#discussion_r1440106348
########## flink-core/src/main/java/org/apache/flink/api/common/functions/RuntimeContext.java: ########## @@ -63,14 +67,27 @@ public interface RuntimeContext { /** * The ID of the current job. Note that Job ID can change in particular upon manual restart. The * returned ID should NOT be used for any job management tasks. + * + * @deprecated This method is deprecated since Flink 1.19. All metadata about the job should be + * provided uniformly by {@link #getJobInfo()}. + * @see <a + * href="https://cwiki.apache.org/confluence/display/FLINK/FLIP-382%3A+Unify+the+Provision+of+Diverse+Metadata+for+Context-like+APIs"> + * FLIP-382: Unify the Provision of Diverse Metadata for Context-like APIs </a> */ + @Deprecated JobID getJobId(); Review Comment: Good point! For these deprecated methods in the modified interfaces, I've changed them from abstract to default and provided default implementations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org