hackergin opened a new pull request, #23990:
URL: https://github.com/apache/flink/pull/23990

   ## What is the purpose of the change
   
   The initialization of CatalogStore is currently before flink-conf.yaml and 
StreamTableEnvironment, which causes the configuration in flink-conf.yaml to 
not take effect. We should move the initialization of CatalogStore after the 
configuration merging.
   
   
   ## Brief change log
   
   * Postponed the discovery of CatalogStoreFactory until the final 
configuration is merged.
   * Using map type options for get CatalogStore confs
   
   
   ## Verifying this change
   
   Add unit test case in org.apache.flink.table.api.EnvironmentTest. Add 
CatalogStore Configuration in EnviromentSetting to verify if the discovery 
logic of CatalogStore can work properly, and whether other Enviroments can 
share the Catalog.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs 
/ not documented)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to