Jiabao-Sun commented on code in PR #23960:
URL: https://github.com/apache/flink/pull/23960#discussion_r1432450266
##########
flink-core/src/test/java/org/apache/flink/api/common/accumulators/AverageAccumulatorTest.java:
##########
@@ -94,19 +94,19 @@ public void testMergeSuccess() {
}
avg1.merge(avg2);
- assertEquals(4.5, avg1.getLocalValue(), 0.0);
+ assertThat(avg1.getLocalValue()).isCloseTo(4.5, within(0.0));
}
@Test
- public void testMergeFailed() {
+ void testMergeFailed() {
AverageAccumulator average = new AverageAccumulator();
Accumulator<Double, Double> averageNew = null;
average.add(1);
try {
average.merge(averageNew);
fail("should fail with an exception");
} catch (IllegalArgumentException e) {
- assertNotNull(e.getMessage());
+ assertThat(e.getMessage()).isNotNull();
Review Comment:
We can use `assertThatThrownBy` to simplify.
##########
flink-core/src/test/java/org/apache/flink/api/common/eventtime/WatermarkOutputMultiplexerTest.java:
##########
@@ -18,24 +18,23 @@
package org.apache.flink.api.common.eventtime;
-import org.junit.Test;
+import org.hamcrest.MatcherAssert;
+import org.junit.jupiter.api.Test;
import java.util.UUID;
import static
org.apache.flink.api.common.eventtime.WatermarkMatchers.watermark;
+import static org.assertj.core.api.AssertionsForClassTypes.assertThat;
Review Comment:
```suggestion
import static org.assertj.core.api.Assertions.assertThat;
```
##########
flink-core/src/test/java/org/apache/flink/api/common/ExecutionConfigFromConfigurationTest.java:
##########
@@ -30,6 +30,7 @@
import java.util.function.Consumer;
import java.util.function.Function;
+import static org.assertj.core.api.AssertionsForClassTypes.assertThat;
import static org.hamcrest.CoreMatchers.equalTo;
import static org.junit.Assert.assertThat;
Review Comment:
```suggestion
import static org.assertj.core.api.Assertions.assertThat;
```
##########
flink-core/src/test/java/org/apache/flink/api/common/functions/util/RuntimeUDFContextTest.java:
##########
@@ -62,13 +60,7 @@ public void testBroadcastVariableNotFound() {
}
try {
- ctx.getBroadcastVariableWithInitializer(
- "some name",
- new BroadcastVariableInitializer<Object, Object>() {
- public Object
initializeBroadcastVariable(Iterable<Object> data) {
- return null;
- }
- });
+ ctx.getBroadcastVariableWithInitializer("some name", data ->
null);
Review Comment:
`assertThatThrownBy`
##########
flink-core/src/test/java/org/apache/flink/api/common/functions/util/RuntimeUDFContextTest.java:
##########
@@ -95,36 +87,36 @@ public void testBroadcastVariableSimple() {
ctx.setBroadcastVariable("name1", Arrays.asList(1, 2, 3, 4));
ctx.setBroadcastVariable("name2", Arrays.asList(1.0, 2.0, 3.0,
4.0));
- assertTrue(ctx.hasBroadcastVariable("name1"));
- assertTrue(ctx.hasBroadcastVariable("name2"));
+ assertThat(ctx.hasBroadcastVariable("name1")).isTrue();
+ assertThat(ctx.hasBroadcastVariable("name2")).isTrue();
List<Integer> list1 = ctx.getBroadcastVariable("name1");
List<Double> list2 = ctx.getBroadcastVariable("name2");
- assertEquals(Arrays.asList(1, 2, 3, 4), list1);
- assertEquals(Arrays.asList(1.0, 2.0, 3.0, 4.0), list2);
+ assertThat(list1).isEqualTo(Arrays.asList(1, 2, 3, 4));
+ assertThat(list2).isEqualTo(Arrays.asList(1.0, 2.0, 3.0, 4.0));
Review Comment:
```suggestion
assertThat(list1).containsExactly(1, 2, 3, 4);
assertThat(list2).containsExactly(1.0, 2.0, 3.0, 4.0);
```
##########
flink-core/src/test/java/org/apache/flink/api/common/ExecutionConfigFromConfigurationTest.java:
##########
@@ -20,7 +20,7 @@
import org.apache.flink.configuration.Configuration;
-import org.junit.Test;
+import org.junit.jupiter.api.Test;
import org.junit.runner.RunWith;
import org.junit.runners.Parameterized;
Review Comment:
```suggestion
import
org.apache.flink.testutils.junit.extensions.parameterized.ParameterizedTestExtension;
import org.apache.flink.testutils.junit.extensions.parameterized.Parameters;
```
##########
flink-core/src/test/java/org/apache/flink/api/common/eventtime/WatermarkOutputMultiplexerTest.java:
##########
@@ -44,12 +43,12 @@ public void singleImmediateWatermark() {
watermarkOutput.emitWatermark(new Watermark(0));
- assertThat(underlyingWatermarkOutput.lastWatermark(),
is(watermark(0)));
- assertThat(underlyingWatermarkOutput.isIdle(), is(false));
+ MatcherAssert.assertThat(underlyingWatermarkOutput.lastWatermark(),
is(watermark(0)));
+ MatcherAssert.assertThat(underlyingWatermarkOutput.isIdle(),
is(false));
Review Comment:
How about assertj?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
