fredia commented on code in PR #23938:
URL: https://github.com/apache/flink/pull/23938#discussion_r1432321260
##########
flink-runtime/src/main/java/org/apache/flink/runtime/state/OperatorStateRestoreOperation.java:
##########
@@ -168,9 +170,25 @@ public Void restore() throws Exception {
}
}
+ // sort state by offsets
+ List<Map.Entry<String, OperatorStateHandle.StateMetaInfo>>
entries =
+
stateHandle.getStateNameToPartitionOffsets().entrySet().stream()
+ .sorted(
+ Comparator.comparingLong(
+ entry -> {
+
OperatorStateHandle.StateMetaInfo
+ stateMetaInfo =
entry.getValue();
+ long[] offsets =
stateMetaInfo.getOffsets();
+ if (offsets == null ||
offsets.length == 0) {
+ return Long.MIN_VALUE;
+ } else {
+ return offsets[0];
+ }
Review Comment:
Thanks for the clarification.
According to the
[constructor](https://github.com/apache/flink/blob/master/flink-runtime/src/main/java/org/apache/flink/runtime/state/OperatorStateHandle.java#L63C17-L63C17)
of `StateMetaInfo` and the
[serde](https://github.com/apache/flink/blob/master/flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/metadata/MetadataV2V3SerializerBase.java#L626)
of `OperatorStateHandle`, I think the `offsets` can not be null. And let it
stay as it is. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
