xuyangzhong commented on code in PR #23760: URL: https://github.com/apache/flink/pull/23760#discussion_r1431313795
########## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/operations/SqlDdlToOperationConverterTest.java: ########## @@ -2210,6 +2211,32 @@ public void testAlterTableDropPartitions() throws Exception { "ALTER TABLE cat1.db1.tb1 DROP IF EXISTS PARTITION (b=1, c=2) PARTITION (b=2)"); } + @Test + public void testCreateViewWithDuplicateFieldName() { + Map<String, String> prop = new HashMap<>(); + prop.put("connector", "values"); + prop.put("bounded", "true"); + CatalogTable catalogTable = + CatalogTable.of( + Schema.newBuilder() + .column("id", DataTypes.BIGINT().notNull()) + .column("uid", DataTypes.BIGINT().notNull()) + .build(), + null, + Collections.emptyList(), + prop); + + catalogManager.createTable( + catalogTable, ObjectIdentifier.of("builtin", "default", "id_table"), false); + + assertThatThrownBy( Review Comment: I think the existent tests can already cover this happy path. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org