dawidwys commented on code in PR #23590:
URL: https://github.com/apache/flink/pull/23590#discussion_r1430305765
##########
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/api/CheckpointBarrierTest.java:
##########
@@ -22,37 +22,29 @@
import org.apache.flink.core.memory.DataOutputSerializer;
import org.apache.flink.runtime.checkpoint.CheckpointOptions;
-import org.junit.Test;
+import org.junit.jupiter.api.Test;
-import static org.junit.Assert.fail;
+import static org.assertj.core.api.Assertions.assertThatThrownBy;
/** Tests for the {@link CheckpointBarrier} type. */
-public class CheckpointBarrierTest {
+class CheckpointBarrierTest {
/**
* Test serialization of the checkpoint barrier. The checkpoint barrier
does not support its own
* serialization, in order to be immutable.
*/
@Test
- public void testSerialization() throws Exception {
+ void testSerialization() {
long id = Integer.MAX_VALUE + 123123L;
long timestamp = Integer.MAX_VALUE + 1228L;
CheckpointOptions options =
CheckpointOptions.forCheckpointWithDefaultLocation();
CheckpointBarrier barrier = new CheckpointBarrier(id, timestamp,
options);
- try {
- barrier.write(new DataOutputSerializer(1024));
- fail("should throw an exception");
Review Comment:
I don't think it adds any value. The `fail("should throw an exception")` is
there simply to make sure, the exception is thrown
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
