[ 
https://issues.apache.org/jira/browse/FLINK-33865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rui Fan updated FLINK-33865:
----------------------------
    Description: 
exponential-delay.attempts-before-reset-backoff doesn't work when it's set in 
Job Configuration.
h2. Reason:

When exponential-delay.attempts-before-reset-backoff is set by job 
Configuration instead of cluster configuration. ExecutionConfig#configure will 
call RestartStrategies#parseConfiguration to create the 
ExponentialDelayRestartStrategyConfiguration. And then 
RestartBackoffTimeStrategyFactoryLoader#getJobRestartStrategyFactory will 
create the ExponentialDelayRestartBackoffTimeStrategyFactory by the 
ExponentialDelayRestartStrategyConfiguration.

Since 1.19, RestartStrategies and RestartStrategyConfiguration are depreated, 
so ExponentialDelayRestartStrategyConfiguration doesn't support 
exponential-delay.attempts-before-reset-backoff. So if we set 
exponential-delay.attempts-before-reset-backoff at job level, it won't be 
supported.
h2. Solution

If we use the ExponentialDelayRestartStrategyConfiguration to save 
restartStrategy related options in the ExecutionConfig, all new options are set 
at job level will be missed. 
So we can use the Configuration to save the restartStrategy options inside of 
ExecutionConfig.

!image-2023-12-17-17-56-59-138.png|width=1212,height=256!

  was:
exponential-delay.attempts-before-reset-backoff doesn't work when it's set in 
Job Configuration.

h2. Reason: 

when exponential-delay.attempts-before-reset-backoff is set by job 
Configuration instead of cluster configuration.

ExecutionConfig#configure will call RestartStrategies#parseConfiguration to 
create the ExponentialDelayRestartStrategyConfiguration. And then 
RestartBackoffTimeStrategyFactoryLoader#getJobRestartStrategyFactory will 
create the ExponentialDelayRestartBackoffTimeStrategyFactory by the 
ExponentialDelayRestartStrategyConfiguration.

Since 1.19, RestartStrategies and RestartStrategyConfiguration are depreated, 
so ExponentialDelayRestartStrategyConfiguration doesn't support 
exponential-delay.attempts-before-reset-backoff. So if we set 
exponential-delay.attempts-before-reset-backoff  at job level, it won't be 
supported.

h2. Solution

If we use the ExponentialDelayRestartStrategyConfiguration to save 
restartStrategy related options in the ExecutionConfig, all new options are set 
at job level will be missed. 
So we can use the Configuration to save the restartStrategy options inside of 
ExecutionConfig.


 !image-2023-12-17-17-56-59-138.png! 


> exponential-delay.attempts-before-reset-backoff doesn't work when it's set in 
> Job Configuration
> -----------------------------------------------------------------------------------------------
>
>                 Key: FLINK-33865
>                 URL: https://issues.apache.org/jira/browse/FLINK-33865
>             Project: Flink
>          Issue Type: Bug
>          Components: Runtime / Coordination
>            Reporter: Rui Fan
>            Assignee: Rui Fan
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: image-2023-12-17-17-56-59-138.png
>
>
> exponential-delay.attempts-before-reset-backoff doesn't work when it's set in 
> Job Configuration.
> h2. Reason:
> When exponential-delay.attempts-before-reset-backoff is set by job 
> Configuration instead of cluster configuration. ExecutionConfig#configure 
> will call RestartStrategies#parseConfiguration to create the 
> ExponentialDelayRestartStrategyConfiguration. And then 
> RestartBackoffTimeStrategyFactoryLoader#getJobRestartStrategyFactory will 
> create the ExponentialDelayRestartBackoffTimeStrategyFactory by the 
> ExponentialDelayRestartStrategyConfiguration.
> Since 1.19, RestartStrategies and RestartStrategyConfiguration are depreated, 
> so ExponentialDelayRestartStrategyConfiguration doesn't support 
> exponential-delay.attempts-before-reset-backoff. So if we set 
> exponential-delay.attempts-before-reset-backoff at job level, it won't be 
> supported.
> h2. Solution
> If we use the ExponentialDelayRestartStrategyConfiguration to save 
> restartStrategy related options in the ExecutionConfig, all new options are 
> set at job level will be missed. 
> So we can use the Configuration to save the restartStrategy options inside of 
> ExecutionConfig.
> !image-2023-12-17-17-56-59-138.png|width=1212,height=256!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to