davidradl commented on code in PR #79:
URL:
https://github.com/apache/flink-connector-jdbc/pull/79#discussion_r1424199289
##########
flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/table/JdbcDynamicTableSourceITCase.java:
##########
@@ -356,6 +356,152 @@ void testLookupJoin(Caching caching) {
}
}
+ @ParameterizedTest
+ @EnumSource(Caching.class)
+ void testLookupJoinWithFilter(Caching caching) {
Review Comment:
Hi @snuyanzin you are correct - I have not changed this. I had a look at
implementing lists for each test case and then having a for loop go through and
execute each testcase based on its data. It got a bit complicated. I am now
trying another approach
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
