snuyanzin commented on code in PR #29:
URL:
https://github.com/apache/flink-connector-shared-utils/pull/29#discussion_r1420148323
##########
.github/workflows/ci.yml:
##########
@@ -59,7 +64,7 @@ jobs:
jdk: [8, 11]
timeout-minutes: ${{ inputs.timeout_global }}
env:
- MVN_COMMON_OPTIONS: -U -B --no-transfer-progress -Dflink.version=${{
inputs.flink_version }}
+ MVN_COMMON_OPTIONS: -U -B --no-transfer-progress -Dflink.version=${{
inputs.flink_version }} -P ${{ inputs.optional_maven_profiles }}
Review Comment:
yep, sure, thanks for potinig to convergence version
good to know
##########
.github/workflows/ci.yml:
##########
@@ -59,7 +64,7 @@ jobs:
jdk: [8, 11]
timeout-minutes: ${{ inputs.timeout_global }}
env:
- MVN_COMMON_OPTIONS: -U -B --no-transfer-progress -Dflink.version=${{
inputs.flink_version }}
+ MVN_COMMON_OPTIONS: -U -B --no-transfer-progress -Dflink.version=${{
inputs.flink_version }} -P ${{ inputs.optional_maven_profiles }}
Review Comment:
yep, sure, thanks for pointinig to convergence version
good to know
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
