jeyhunkarimov commented on PR #23586: URL: https://github.com/apache/flink/pull/23586#issuecomment-1838902148
> > Mainly because of this comment: https://github.com/apache/flink/blob/7eaa5db30244b8b5d9cdc6ab0cb327e255d6fadc/flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/LookupJoinITCase.scala#L430 > > IMHO then it would make sense first to answer the question what is correct approach and why Thanks for the comment @snuyanzin My main reasoning behind the refactor is that `createTemporarySystemFunction` creates global functions. These (permanent) functions are overriden by temporary functions. To make sure that we are testing the correct function, it might make sense to force override the global functions (if they exists). WDYT? - -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
