[
https://issues.apache.org/jira/browse/FLINK-25857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17789995#comment-17789995
]
Leonard Xu edited comment on FLINK-25857 at 11/27/23 9:39 AM:
--------------------------------------------------------------
[~pvary] I am very surprised that the public interface was removed without
being discussed in the community dev mailing list. The previously voted
FLIP-371[1] does not involve this modification. I fully understand that the
implementation of some voted FLIPs may also involve modifications to the public
interface, but at this time we should return to the dev mailing list to
continue the discussion, rather than closing it directly after discussing it in
the github PR. Moreover, even if it was discussed in github, [~jiabao.sun] had
already pointed out this problem[2], but the PR was still merged without
resolving jiabao's reasonable concerns. To be honest, I think this is incorrect
both in terms of the community FLIP process and the PR review process.
CC: [~martijnvisser] [~mbalassi] [~danny.cranmer]
[1]
https://cwiki.apache.org/confluence/display/FLINK/FLIP-371%3A+Provide+initialization+context+for+Committer+creation+in+TwoPhaseCommittingSink
[2] https://github.com/apache/flink/pull/23555/files#r1399035189
was (Author: leonard xu):
[~pvary] I am very surprised that the public interface was removed without
being discussed in the community dev mailing list. The previously voted
FLIP-371[1] does not involve this modification. I fully understand that the
implementation of some voted FLIPs may also involve modifications to the public
interface, but at this time we should return to the dev mailing list to
continue the discussion, rather than closing it directly after discussing it in
the github PR. Moreover, even if it was discussed in github, [~jiabao.sun] had
already pointed out this problem[2], but the PR was still merged without
resolving jiabao's reasonable concerns. To be honest, I think this is incorrect
both in terms of the community FLIP process and the PR review process.
CC: [~martijnvisser] [~mbalassi] [~danny.cranmer]
[1]
https://cwiki.apache.org/confluence/display/FLINK/FLIP-321%3A+Introduce+an+API+deprecation+process
[2] https://github.com/apache/flink/pull/23555/files#r1399035189
> Add committer metrics to track the status of committables
> ---------------------------------------------------------
>
> Key: FLINK-25857
> URL: https://issues.apache.org/jira/browse/FLINK-25857
> Project: Flink
> Issue Type: Sub-task
> Components: Connectors / Common
> Reporter: Fabian Paul
> Assignee: Peter Vary
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.19.0
>
> Attachments: image-2023-10-20-17-23-09-595.png, screenshot-1.png
>
>
> With Sink V2 we can now track the progress of a committable during committing
> and show metrics about the committing status. (i.e. failed, retried,
> succeeded).
> The voted FLIP
> https://cwiki.apache.org/confluence/display/FLINK/FLIP-371%3A+Provide+initialization+context+for+Committer+creation+in+TwoPhaseCommittingSink
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
