mayuehappy commented on code in PR #23765:
URL: https://github.com/apache/flink/pull/23765#discussion_r1405583287
##########
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/snapshot/RocksIncrementalSnapshotStrategy.java:
##########
@@ -350,6 +359,10 @@ private long uploadSnapshotFiles(
? CheckpointedStateScope.EXCLUSIVE
: CheckpointedStateScope.SHARED;
+ if (stateFileVerifier != null) {
+ stateFileVerifier.verifySstFilesChecksum(sstFilePaths);
+ }
+
List<HandleAndLocalPath> sstFilesUploadResult =
stateUploader.uploadFilesToCheckpointFs(
Review Comment:
> > most files are damaged due to hardware failures on the machine where the
file is written
>
> Check with you first, if there is hardware failures after the file is
written,, doesn't this issue happen?
Well, just like I replied to you in the ticket, I think this possibility is
very small. We can continue the discussion in the ticket and then come back to
continue reviewing this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
