snuyanzin commented on code in PR #23751:
URL: https://github.com/apache/flink/pull/23751#discussion_r1400588039
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/utils/UserDefinedFunctionTestUtils.scala:
##########
@@ -275,21 +296,44 @@ object UserDefinedFunctionTestUtils {
object MyPojoFunc extends ScalarFunction {
def eval(s: MyPojo): Int = s.f2
- override def getParameterTypes(signature: Array[Class[_]]):
Array[TypeInformation[_]] =
- Array(MyToPojoFunc.getResultType(signature))
+ override def getTypeInference(typeFactory: DataTypeFactory): TypeInference
= {
+ TypeInference.newBuilder
+ .typedArguments(
+ DataTypes.STRUCTURED(
+ classOf[MyPojo],
+ DataTypes.FIELD("f1", DataTypes.INT()),
+ DataTypes.FIELD("f2", DataTypes.INT())))
+ .outputTypeStrategy((call: CallContext) =>
Optional.of(DataTypes.INT().notNull()))
+ .build
+ }
}
@SerialVersionUID(1L)
object MyToPojoFunc extends ScalarFunction {
- def eval(s: Int): MyPojo = new MyPojo(s, s)
- override def getResultType(signature: Array[Class[_]]):
PojoTypeInfo[MyPojo] = {
+ def eval(s: Int) = new MyPojo(s, s)
+
+ /*override def getResultType(signature: Array[Class[_]]):
PojoTypeInfo[MyPojo] = {
Review Comment:
done
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/utils/CountAggFunction.scala:
##########
@@ -20,8 +20,11 @@ package org.apache.flink.table.planner.utils
import org.apache.flink.api.common.typeinfo.{BasicTypeInfo, TypeInformation}
import org.apache.flink.api.java.tuple.{Tuple1 => JTuple1}
import org.apache.flink.api.java.typeutils.TupleTypeInfo
-import org.apache.flink.table.api.Types
+import org.apache.flink.table.annotation.DataTypeHint
+import org.apache.flink.table.api.{DataTypes, Types}
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
