XComp commented on code in PR #23544: URL: https://github.com/apache/flink/pull/23544#discussion_r1400467360
########## tools/releasing/create_binary_release.sh: ########## @@ -17,6 +17,9 @@ # limitations under the License. # +## check required Java and Maven version Review Comment: Yes, I [provided the code above](https://github.com/apache/flink/pull/23544#discussion_r1371232099) in case you still want to add this kind of check. It, at least, reduces the number of code redundancies (in terms of the Maven version) in comparison to the initial version of this PR. But [my comment above](https://github.com/apache/flink/pull/23544#discussion_r1371235162) still stands that the check itself is not really necessary for the stated reasons. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
