Re: [PR] [FLINK-32881][checkpoint] Support triggering savepoint in detach mode for CLI and dumping all pending savepoint ids by rest api [flink]

[via GitHub]

xiangforever2014 commented on PR #23253:
URL: https://github.com/apache/flink/pull/23253#issuecomment-1820273335

   @masteryhx Many thanks for your suggestion, and I have followed your advice 
to simplify the code.
   I have tested in my local machine, when triggering a detached savepoint, the 
CLI will return with a trigger id immediately, and I could use the trigger id 
to get the status of the savepoint by REST API 
[/jobs/:jobid/savepoints/:triggerid 
](https://nightlies.apache.org/flink/flink-docs-release-1.18/docs/ops/rest_api/#jobs-jobid-savepoints-triggerid).
   
   Triggering a savepoint vs. Triggering a detached savepoint:
   1. Triggering a savepoint: from the picture, we could see that the CLI 
should wait for the savepoint to be finished, and it is very easy to cause a 
CLI timeout when the state of the job is huge.
   
![image](https://github.com/apache/flink/assets/23545296/ee4e5cf2-cb19-40c3-bcc2-3c558c952593)
   
   2. Triggering a detached savepoint: the CLI returned with the trigger id 
immediately, and we could get the status of the savepoint by REST API.
   
![img_v3_025d_dad79492-1bae-4843-bb1e-42370cf2b52g](https://github.com/apache/flink/assets/23545296/d0b20561-bf0e-42cc-97a5-bfb3c387c29c)
   
   - when the savepoint has not finished, we get
   
![img_v3_025d_982195b1-b21c-418f-8752-73d13ff2564g](https://github.com/apache/flink/assets/23545296/daa1874f-2902-47f8-8efe-3c8923dbb225)
   
   - once the savepoint finished, we get
   
![img_v3_025d_e064e7aa-147b-4a31-b3eb-9bc3accaa85g](https://github.com/apache/flink/assets/23545296/011c8e52-bd37-4215-b09f-31dcc013f7b0)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org