afedulov commented on PR #23553:
URL: https://github.com/apache/flink/pull/23553#issuecomment-1816655632
@zentol some thoughts:
- I like the idea of exposing `fromData`. There is no good reason for both
`fromElements` and and `fromCollection` methods to exist - they do the same
thing and are described in their entirety by the method parameters.
- Keeping `fromData` on the environment has some benefits:
- Exposing factory methods on the `DataGenerator` for this purpose
semantically could look a bit weird when all users want is to send some static
data - it gives a bit of a wrong impression that this data is expected to be
the basis for some generated dataset, maybe just looped over or something like
this
- The fact that we use the DataGenerator for under the hood could be
seen as an implementation detail. Should the modules layout change in 2.0,
we'll be free to change the underlying implementation if needed.
I am in favor of exposing the `fromData` method and deprecating
`fromElements` and `fromCollection`. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
