davidradl commented on PR #79:
URL: 
https://github.com/apache/flink-connector-jdbc/pull/79#issuecomment-1816649638

   > can we also add a test to 
`org.apache.flink.connector.jdbc.table.JdbcTablePlanTest` to be sure that the 
execution plan is expected?
   
   I will have a look there are currently no join tests here, and the tests are 
not working locally on my Mac (not related to this change). I agree is would be 
good to add - I am not sure this should stop the merge - as this issue is a 
critical blocker.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to