davidradl commented on code in PR #77:
URL:
https://github.com/apache/flink-connector-jdbc/pull/77#discussion_r1397462056
##########
flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/internal/JdbcOutputFormat.java:
##########
@@ -153,6 +153,16 @@ public void open(int taskNumber, int numTasks) throws
IOException {
if (!closed) {
try {
flush();
+ } catch (FlushingRuntimeException e) {
+ /*
+ * We ignore this
FlushingRuntimeException, as it is
+ * only thrown when
flushingException was assigned to,
+ * in a former run of this
scheduler thread, in the next
+ * catch clause. In that case, we
already have
+ * flushException cached, waiting
for the next task
+ * manager thread's flush call
which would throw a new
+ * FlushingRuntimeException
causing job failure.
Review Comment:
There is another case in this class where there is a flush() and is issues a
RuntimeException, should we use the new Exception and catch it there as well;
or can this case never loop. There are other calls to flush() - do we think
these are not effected?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
