dawidwys commented on code in PR #23735:
URL: https://github.com/apache/flink/pull/23735#discussion_r1395745935


##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/SpecificInputTypeStrategies.java:
##########
@@ -65,6 +65,11 @@ public static InputTypeStrategy 
windowTimeIndicator(TimestampKind timestampKind)
         return new WindowTimeIndictorInputTypeStrategy(timestampKind);
     }
 
+    /** See {@link WindowTimeIndictorInputTypeStrategy}. */
+    public static InputTypeStrategy windowTimeIndicator() {
+        return new WindowTimeIndictorInputTypeStrategy(null);

Review Comment:
   When we pass it as null? The parameter is used to configure the behaviour of 
the `WindowTimeIndictorInputTypeStrategy` class. If we configure it with `null` 
we don't perform the specific checks for `PROCTIME`, `ROWTIME` attributes. We 
just check that the argument is of any of the two.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to