gfmio commented on code in PR #336:
URL: https://github.com/apache/flink-statefun/pull/336#discussion_r1395492175
##########
statefun-flink/statefun-flink-io-bundle/src/main/java/org/apache/flink/statefun/flink/io/kafka/binders/ingress/v1/RoutableKafkaIngressDeserializer.java:
##########
@@ -45,7 +45,7 @@ public RoutableKafkaIngressDeserializer(Map<String,
RoutingConfig> routingConfig
public Message deserialize(ConsumerRecord<byte[], byte[]> input) {
final String topic = input.topic();
final byte[] payload = input.value();
- final byte[] key = requireNonNullKey(input.key());
Review Comment:
That might work. The `NoOpDeserliazer` just returns `null`, which could be
done here as well.
https://github.com/apache/flink-statefun/blob/accd75ea0109845c4b4c0ddd74021147af1439d4/statefun-kafka-io/src/test/java/org/apache/flink/statefun/sdk/kafka/KafkaIngressBuilderTest.java#L166
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
