Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/2729#discussion_r87202166
--- Diff: flink-java/src/main/java/org/apache/flink/api/java/DataSet.java
---
@@ -181,7 +181,17 @@ protected void fillInType(TypeInformation<T> typeInfo)
{
return this.type;
}
+ /**
+ * 1. Check if the function is implemented by a scala object. Checks
only if scala object function forbidden
+ * is not disabled in the
[[org.apache.flink.api.common.ExecutionConfig]]
+ *
+ * 2. Returns a "closure-cleaned" version of the given function.
Cleans only if closure cleaning
+ * is not disabled in the
[[org.apache.flink.api.common.ExecutionConfig]]
+ */
public <F> F clean(F f) {
--- End diff --
I suggest to move this check in a separate method like:
```public <F> F checkNotSingleton(F f)```
One method should typically have one single duty, and the duty of a
cleaning function should not be checking for singleton objects. Both functions
could then be chained however into `clean(check(f))`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
