gyfora commented on code in PR #710: URL: https://github.com/apache/flink-kubernetes-operator/pull/710#discussion_r1393008888
########## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/state/ConfigMapView.java: ########## @@ -0,0 +1,111 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.kubernetes.operator.autoscaler.state; + +import org.apache.flink.annotation.VisibleForTesting; +import org.apache.flink.util.Preconditions; + +import io.fabric8.kubernetes.api.model.ConfigMap; +import io.fabric8.kubernetes.client.dsl.Resource; + +import java.util.Collections; +import java.util.Map; +import java.util.function.Function; +import java.util.function.Supplier; + +class ConfigMapView { + + enum State { + NEEDS_CREATE, + NEEDS_UPDATE, + UP_TO_DATE + } + + private State state; + + private ConfigMap configMap; + + private final Function<ConfigMap, Resource<ConfigMap>> resourceRetriever; + + public ConfigMapView( + Supplier<ConfigMap> configMapRetriever, + Supplier<ConfigMap> configMapBuilder, + Function<ConfigMap, Resource<ConfigMap>> resourceRetriever) { + var existingConfigMap = configMapRetriever.get(); + if (existingConfigMap != null) { + refreshConfigMap(existingConfigMap); + } else { + this.configMap = configMapBuilder.get(); + this.state = State.NEEDS_CREATE; + } + this.resourceRetriever = resourceRetriever; Review Comment: I think we could further simplify this by keeping only: ``` Resource<ConfigMap> resource: ConfigMap configMap; State state; ``` And pass those directly in the constructor / through a static create method instead of the Suppliers/Functions which feel a bit unnecessary ########## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/state/ConfigMapView.java: ########## @@ -0,0 +1,111 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.kubernetes.operator.autoscaler.state; + +import org.apache.flink.annotation.VisibleForTesting; +import org.apache.flink.util.Preconditions; + +import io.fabric8.kubernetes.api.model.ConfigMap; +import io.fabric8.kubernetes.client.dsl.Resource; + +import java.util.Collections; +import java.util.Map; +import java.util.function.Function; +import java.util.function.Supplier; + +class ConfigMapView { + + enum State { + NEEDS_CREATE, + NEEDS_UPDATE, + UP_TO_DATE + } + + private State state; + + private ConfigMap configMap; + + private final Function<ConfigMap, Resource<ConfigMap>> resourceRetriever; + + public ConfigMapView( + Supplier<ConfigMap> configMapRetriever, + Supplier<ConfigMap> configMapBuilder, + Function<ConfigMap, Resource<ConfigMap>> resourceRetriever) { + var existingConfigMap = configMapRetriever.get(); + if (existingConfigMap != null) { + refreshConfigMap(existingConfigMap); + } else { + this.configMap = configMapBuilder.get(); + this.state = State.NEEDS_CREATE; Review Comment: I am not super familiar with the `Resource<T>` class but couldn't we use it also to get the `ConfigMap`? Then we could simply use that and don't need the `configMapRetriever` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
