Apache9 commented on code in PR #23593:
URL: https://github.com/apache/flink/pull/23593#discussion_r1375399529
##########
flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/source/hybrid/HybridSourceSplitEnumerator.java:
##########
@@ -304,6 +304,7 @@ public Object getPreviousEnumerator() {
LOG.info("Starting enumerator for sourceIndex={}", currentSourceIndex);
context.setIsProcessingBacklog(currentSourceIndex < sources.size() -
1);
currentEnumerator.start();
+ finishedReaders.clear();
Review Comment:
I guess you mean line 261?
https://github.com/apache/flink/blob/c1be70bbc60e4271d9ff80ac4eaf3421d7602058/flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/source/hybrid/HybridSourceSplitEnumerator.java#L261
Line 251 is for closing the HybridEnumerator itself, so whether to cleanup
the finishedReaders is not critial, as we will not use this hybrid enumerator
any more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
