Samrat002 commented on code in PR #23531:
URL: https://github.com/apache/flink/pull/23531#discussion_r1374920762
##########
flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/JobResultStoreOptions.java:
##########
@@ -65,4 +65,11 @@ public class JobResultStoreOptions {
+ "are, instead, marked as clean to
indicate their state. In this "
+ "case, Flink no longer has ownership and
the resources need to "
+ "be cleaned up by the user.");
+
+
@Documentation.Section(Documentation.Sections.COMMON_HIGH_AVAILABILITY_JOB_RESULT_STORE)
+ public static final ConfigOption<Integer> TIME_TO_REMOVE_CLEAN_JOB_RESULT =
Review Comment:
I completely agree with your point. We should definitely consider extending
this functionality to the file-based JobResultStore. As you suggested, starting
a ML discussion seems appropriate. If we decide to expand the scope to the
file-based system, following your earlier suggestion, it might be worth
considering a FLIP.
##########
flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/JobResultStoreOptions.java:
##########
@@ -65,4 +65,11 @@ public class JobResultStoreOptions {
+ "are, instead, marked as clean to
indicate their state. In this "
+ "case, Flink no longer has ownership and
the resources need to "
+ "be cleaned up by the user.");
+
+
@Documentation.Section(Documentation.Sections.COMMON_HIGH_AVAILABILITY_JOB_RESULT_STORE)
+ public static final ConfigOption<Integer> TIME_TO_REMOVE_CLEAN_JOB_RESULT =
+ ConfigOptions.key("job-result-store.ttl-clean-job-result")
Review Comment:
> But this keeps me wondering: Shouldn't we also offer this functionality to
the file-based JobResultStore?
I completely agree with your point. We should definitely consider extending
this functionality to the file-based `JobResultStore`. As you suggested,
starting a ML discussion seems appropriate. If we decide to expand the scope to
the file-based system, following your earlier suggestion, it might be worth
considering a FLIP.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
