Jiabao-Sun commented on code in PR #17:
URL:
https://github.com/apache/flink-connector-mongodb/pull/17#discussion_r1374455479
##########
flink-connector-mongodb/src/test/java/org/apache/flink/connector/mongodb/source/MongoSourceITCase.java:
##########
@@ -76,7 +76,7 @@
/** IT cases for using Mongo Sink. */
@Testcontainers
-public class MongoSourceITCase {
+class MongoSourceITCase {
Review Comment:
> Test Classes and Methods
In JUnit 5, test classes, test methods, and lifecycle methods are not
required to be public, but they must not be private. And the [JUnit5 user guide
](https://junit.org/junit5/docs/snapshot/user-guide/#writing-tests-classes-and-methods)recommends
omitting the public modifier for them unless there is a technical reason – for
example, when a test class is extended by a test class in another package. So
please follow this rule in the migration.
Refers to
-
https://docs.google.com/document/d/1514Wa_aNB9bJUen4xm5uiuXOooOJTtXqS_Jqk9KJitU/edit#heading=h.4iilyfqpoiw2
- https://issues.apache.org/jira/browse/FLINK-25325
##########
flink-connector-mongodb/src/test/java/org/apache/flink/connector/mongodb/source/MongoSourceITCase.java:
##########
@@ -76,7 +76,7 @@
/** IT cases for using Mongo Sink. */
@Testcontainers
-public class MongoSourceITCase {
+class MongoSourceITCase {
Review Comment:
> Test Classes and Methods
In JUnit 5, test classes, test methods, and lifecycle methods are not
required to be public, but they must not be private. And the [JUnit5 user guide
](https://junit.org/junit5/docs/snapshot/user-guide/#writing-tests-classes-and-methods)recommends
omitting the public modifier for them unless there is a technical reason – for
example, when a test class is extended by a test class in another package. So
please follow this rule in the migration.
Refers to
-
https://docs.google.com/document/d/1514Wa_aNB9bJUen4xm5uiuXOooOJTtXqS_Jqk9KJitU/edit#heading=h.4iilyfqpoiw2
- https://issues.apache.org/jira/browse/FLINK-25325
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
